Re: [PATCH] memcg-v1: Enable setting memory min, low, high

From: kernel test robot
Date: Tue Apr 04 2023 - 22:22:04 EST


Hi Shaun,

kernel test robot noticed the following build errors:

[auto build test ERROR on v6.3-rc5]
[also build test ERROR on linus/master]
[cannot apply to akpm-mm/mm-everything next-20230404]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Shaun-Tancheff/memcg-v1-Enable-setting-memory-min-low-high/20230405-045143
patch link: https://lore.kernel.org/r/20230404205013.31520-1-shaun.tancheff%40gmail.com
patch subject: [PATCH] memcg-v1: Enable setting memory min, low, high
config: i386-randconfig-a011-20230403 (https://download.01.org/0day-ci/archive/20230405/202304051011.6E3fABwV-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/180e4266c809a61c2711599c6462bd719efed76c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Shaun-Tancheff/memcg-v1-Enable-setting-memory-min-low-high/20230405-045143
git checkout 180e4266c809a61c2711599c6462bd719efed76c
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 olddefconfig
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202304051011.6E3fABwV-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

ld: mm/memcontrol.o: in function `mem_cgroup_v1_set_defaults':
>> mm/memcontrol.c:3878: undefined reference to `__udivdi3'


vim +3878 mm/memcontrol.c

3853
3854 static inline void mem_cgroup_v1_set_defaults(struct mem_cgroup *memcg,
3855 u64 nr_pages)
3856 {
3857 u64 max = (u64)(PAGE_COUNTER_MAX * PAGE_SIZE) / PAGE_SIZE;
3858 u64 min, low, high;
3859
3860 if (mem_cgroup_is_root(memcg) || max == nr_pages)
3861 return;
3862
3863 min = READ_ONCE(memcg->memory.min);
3864 low = READ_ONCE(memcg->memory.low);
3865 if (min || low)
3866 return;
3867
3868 if (!min && memcg_v1_min_default_percent) {
3869 min = (nr_pages * memcg_v1_min_default_percent) / 100;
3870 page_counter_set_min(&memcg->memory, min);
3871 }
3872 if (!low && memcg_v1_low_default_percent) {
3873 low = (nr_pages * memcg_v1_low_default_percent) / 100;
3874 page_counter_set_low(&memcg->memory, low);
3875 }
3876 high = READ_ONCE(memcg->memory.high);
3877 if (high == PAGE_COUNTER_MAX && memcg_v1_high_default_percent) {
> 3878 high = (nr_pages * memcg_v1_high_default_percent) / 100;
3879 page_counter_set_high(&memcg->memory, high);
3880 }
3881 }
3882

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests