Re: [PATCH 18/32] perf/alibaba_uncore: Assign parents for event_source device

[Shuai Xue]

On 2023/4/4 PM9:42, Jonathan Cameron wrote:
> Currently the PMU device appears directly under /sys/devices/
> Only root busses should appear there, so instead assign the pmu->dev
> parent to be the platform device.
> 
> Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@xxxxxxxxx/
> Cc: Shuai Xue <xueshuai@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> ---
>  drivers/perf/alibaba_uncore_drw_pmu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c
> index a7689fecb49d..0d129acf3f84 100644
> --- a/drivers/perf/alibaba_uncore_drw_pmu.c
> +++ b/drivers/perf/alibaba_uncore_drw_pmu.c
> @@ -683,6 +683,7 @@ static int ali_drw_pmu_probe(struct platform_device *pdev)
>  
>  	drw_pmu->pmu = (struct pmu) {
>  		.module		= THIS_MODULE,
> +		.parent		= &pdev->dev,
>  		.task_ctx_nr	= perf_invalid_context,
>  		.event_init	= ali_drw_pmu_event_init,
>  		.add		= ali_drw_pmu_add,


Reviewed-by: Shuai Xue <xueshuai@xxxxxxxxxxxxxxxxx>

Thank you.

Best Regards,
Shuai