Re: [PATCH v2 01/11] virt: sev-guest: Use AES GCM crypto library

From: Nikunj A. Dadhania
Date: Wed Apr 05 2023 - 01:10:36 EST


On 4/4/2023 12:39 AM, Tom Lendacky wrote:
> On 3/26/23 09:46, Nikunj A Dadhania wrote:
>> SEV-SNP guests with SecureTSC enabled need to send a TSC_INFO SNP
>> Guest message to the AMD security processor before the smpboot phase
>> starts. Details from the TSC_INFO response have to be programmed in
>> the VMSA before the secondary CPUs are brought up.
>>
>> Start using the AES GCM library implementation as the crypto API is not
>> available yet this early.
>
> This isn't quite true, yet. You should add that the encryption code will
> be moved out of sev-guest to support Secure TSC, but to make the diffs> easier to review, convert the Crypto API usage over to AES GCM library > usage before moving it.

Yes, will change it accordingly.

Regards
Nikunj