Re: [PATCH V2 5/9] dt-bindings: PCI: qcom: Add IPQ9574

From: Krzysztof Kozlowski
Date: Wed Apr 05 2023 - 02:58:14 EST


On 04/04/2023 18:48, Devi Priya wrote:
> Add bindings for PCIe hosts on IPQ9574 platform and allow
> msi-parent property

Missing full stop. Also in your other patches.

>
> Signed-off-by: Devi Priya <quic_devipriy@xxxxxxxxxxx>
> ---
> Changes in V2:
> - Updated the commit message and dropped the aggr_noc entries
> as it will be handled via interconnect driver
>
> .../devicetree/bindings/pci/qcom,pcie.yaml | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> index fb32c43dd12d..8657ab65008c 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> @@ -26,6 +26,7 @@ properties:
> - qcom,pcie-ipq8064-v2
> - qcom,pcie-ipq8074
> - qcom,pcie-ipq8074-gen3
> + - qcom,pcie-ipq9574
> - qcom,pcie-msm8996
> - qcom,pcie-qcs404
> - qcom,pcie-sa8540p
> @@ -105,6 +106,8 @@ properties:
> items:
> - const: pciephy
>
> + msi-parent: true

Isn't this conflicting with Mani's series:
https://lore.kernel.org/all/20230108203340.GA229573-robh@xxxxxxxxxx/
https://lore.kernel.org/all/20230111123004.21048-1-manivannan.sadhasivam@xxxxxxxxxx/#t

Although for some reason Mani's patch references non-existing commit and
hunk...

Best regards,
Krzysztof