Re: [PATCH v2] selftests/clone3: fix number of tests in ksft_set_plan
From: Christian Brauner
Date: Wed Apr 05 2023 - 03:46:21 EST
On Mon, Apr 03, 2023 at 10:57:37PM +0200, Tobias Klauser wrote:
> On 2023-03-14 at 14:09:59 +0100, Christian Brauner <brauner@xxxxxxxxxx> wrote:
> > On Tue, Mar 14, 2023 at 01:34:14PM +0100, Tobias Klauser wrote:
> > > Commit 515bddf0ec41 ("selftests/clone3: test clone3 with CLONE_NEWTIME")
> > > added an additional test, so the number passed to ksft_set_plan needs to
> > > be bumped accordingly.
> > >
> > > Also use ksft_finished() to print results and exit. This will catch future
> > > mismatches between ksft_set_plan() and the number of tests being run.
> > >
> > > Fixes: 515bddf0ec41 ("selftests/clone3: test clone3 with CLONE_NEWTIME")
> > > Cc: Christian Brauner <brauner@xxxxxxxxxx>
> > > Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxx>
> > > ---
> >
> > Looks good. Thanks for fixing this,
> > Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>
> >
> > Feel free to take this through the selftests tree, Shuah.
>
> It looks like this hasn't made it into Linus' tree yet and I also don't
> see it in Shuah's tree. Would it be possible to still submit this for
> 6.3-rc6 given the commit it fixes has made it to Linus' tree already?
Is it in linux-next?