Re: [PATCH v3 6/8] workingset: memcg: sleep when flushing stats in workingset_refault()

From: Michal Koutný
Date: Wed Apr 05 2023 - 04:00:55 EST


On Tue, Apr 04, 2023 at 11:09:02AM -0700, Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote:
> IIUC there are multiple places where we can sleep in this path, we can
> sleep waiting for a page to be read from disk, we can sleep during
> allocating the page to read into, and IIUC the allocations on the
> fault path can even run into reclaim, going into the vmscan code. So
> there are precedents, but I am not sure if that's enough argument.

I expect it'd depend on the proportion of the slow/fast paths.
OK, let's see how it turns out in wider population.

Thanks,
Michal

Attachment: signature.asc
Description: PGP signature