Re: [PATCH v2 1/3] regulator: da9063: add voltage monitoring registers

[Benjamin Bara]

Thank you for the feedback!

On Wed, 5 Apr 2023 at 09:29, Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:
> Just a very minor thing - wouldn't this check be better as:
> if (regl->info->vmon.mask) ?
> We may have device(s) where 0 is a valid reg. However, mask 0 is
> probably not making sense - unless I misunderstand something?

This config is specific to the da9063. On this IC, register 0 is used for
PAGE_CON (control register). The registers relevant for voltage monitoring are
on 0x115-0x117. So IMHO this should be fine.