Re: [PATCH v2] media: venus: dec: Fix handling of the start cmd

[Dikshita Agarwal]

On 4/5/2023 2:59 PM, Michał Krawczyk wrote:
> Hi,
>
> just a kindly reminder about the patch.
>
> Thanks,
> Michał

Hi Michal,

this patch is part of latest PR 
https://patchwork.linuxtv.org/project/linux-media/patch/20230404192722.144496-1-stanimir.k.varbanov@xxxxxxxxx/ 


Thanks,

Dikshita

> pt., 10 mar 2023 o 16:05 Michał Krawczyk <mk@xxxxxxxxxxxx> napisał(a):
> > Hi,
> >
> > Any update on this patch? It would be great if we could make some
> > progress there (and, hopefully, finally merge it :))
> >
> > Thanks,
> > Michał
> >
> > pt., 10 lut 2023 o 16:18 Michał Krawczyk <mk@xxxxxxxxxxxx> napisał(a):
> > > Hi,
> > >
> > > I'm wondering if there are any more comments for this patch? I would
> > > be happy to clarify anything that's unclear or improve the code if
> > > needed.
> > >
> > > I know it's pretty late, but it would be really great if this fix
> > > could land before v6.2 is released, so I'd appreciate your help and
> > > review.
> > >
> > > Thank you,
> > > Michał
> > >
> > > wt., 7 lut 2023 o 12:15 Michał Krawczyk <mk@xxxxxxxxxxxx> napisał(a):
> > > > wt., 7 lut 2023 o 10:54 Vikash Garodia <vgarodia@xxxxxxxxxxxxxxxx> napisał(a):
> > > > > I have reviewed the patch, and the drain sequence handling looks good to me.
> > > > > Could you share some details on the test client which you are using to catch this issue ?
> > > > Hi Vikash,
> > > >
> > > > Thank you for looking at the code!
> > > >
> > > > I've been testing it using the Chromium implementation of the V4L2
> > > > codec [1]. Meanwhile, we were running a test suite which changes the
> > > > encryption method in the middle of the video decoding. This triggers
> > > > the flush behavior and the Chromium sends the stop/start cmd to the
> > > > V4L2 kernel component, and the test expects the video to continue the
> > > > playback normally. Unfortunately, it was causing a stall of the video
> > > > at the same time.
> > > >
> > > > [1] https://source.chromium.org/chromium/chromium/src/+/main:media/gpu/v4l2/
> > > >
> > > > > > Thank you,
> > > > > > Michał
> > > > > Thanks,
> > > > > Vikash