Re: [PATCH net 1/1] net: stmmac: check fwnode for phy device before scanning for phy

From: Marek Szyprowski
Date: Wed Apr 05 2023 - 06:54:09 EST


On 05.04.2023 12:07, Shahab Vahedi wrote:
> On 4/5/23 11:39, Michael Sit Wei Hong wrote:
>> Some DT devices already have phy device configured in the DT/ACPI.
>> Current implementation scans for a phy unconditionally even though
>> there is a phy listed in the DT/ACPI and already attached.
>>
>> We should check the fwnode if there is any phy device listed in
>> fwnode and decide whether to scan for a phy to attach to.y
>>
>> Reported-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
>> Fixes: fe2cfbc96803 ("net: stmmac: check if MAC needs to attach to a PHY")
>> Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@xxxxxxxxx>
>> ---
> Works fine on ARC HSDK board.
> Tested-by: Shahab Vahedi <shahab@xxxxxxxxxxxx>

Tested-by: Marek Szyprowski

Works fine on Khadas VIM3, Odroid-C4 and Odroid-M1.

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland