Re: [PATCH] nvmem: layouts: sl28vpd: set varaiable sl28vpd_layout storage-class-specifier to static

[Tom Rix]

On 4/4/23 12:09 PM, Michael Walle wrote:
> Am 2023-04-04 18:36, schrieb Tom Rix:
> > smatch reports
> > drivers/nvmem/layouts/sl28vpd.c:144:21: warning: symbol
> >   'sl28vpd_layout' was not declared. Should it be static?
> >
> > This variable is only used in one file so it should be static.
> >
> > Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
>
> Fixes tag?
I am cleaning all of the similar reports by smatch, there is a couple 
hundred.

Because the code works as-is, I do not consider them broken and needing 
fixes tags.

However I do not mind adding then if they are required.

Tom

> Reviewed-by: Michael Walle <michael@xxxxxxxx>
>
> -michael