Re: [PATCH 2/3] venus: firmware: Correct non-pix start and end addresses

[Linux regression tracking #update (Thorsten Leemhuis)]

[TLDR: This mail in primarily relevant for Linux kernel regression
tracking. See link in footer if these mails annoy you.]

On 05.02.23 12:00, Linux kernel regression tracking (#adding) wrote:

> On 26.01.23 20:19, Matthias Kaehlcke wrote:
> 
>> On Wed, Oct 05, 2022 at 11:37:29AM +0300, Stanimir Varbanov wrote:
>>> The default values for those registers are zero.
>>>
>>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>
>>> ---
>>>  drivers/media/platform/qcom/venus/firmware.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c
>>> index 3851cedc3329..71e43611d1cf 100644
>>> --- a/drivers/media/platform/qcom/venus/firmware.c
>>> +++ b/drivers/media/platform/qcom/venus/firmware.c
>>> @@ -38,8 +38,8 @@ static void venus_reset_cpu(struct venus_core *core)
>>>  	writel(fw_size, wrapper_base + WRAPPER_FW_END_ADDR);
>>>  	writel(0, wrapper_base + WRAPPER_CPA_START_ADDR);
>>>  	writel(fw_size, wrapper_base + WRAPPER_CPA_END_ADDR);
>>> -	writel(fw_size, wrapper_base + WRAPPER_NONPIX_START_ADDR);
>>> -	writel(fw_size, wrapper_base + WRAPPER_NONPIX_END_ADDR);
>>> +	writel(0, wrapper_base + WRAPPER_NONPIX_START_ADDR);
>>> +	writel(0, wrapper_base + WRAPPER_NONPIX_END_ADDR);
>>>  
>>>  	if (IS_V6(core)) {
>>>  		/* Bring XTSS out of reset */
>>
>> I found that this commit prevents the AOSS from entering sleep mode during
>> system suspend at least on sc7180 and sc7280. AOSS not entering sleep mode
>> leads to a (apparently significant) increase in S3 power consumption, on
>> trogdor and herobrine it prevents the system from staying suspended, because
>> the embedded controller detect the condition and wakes the sytem up again.
> 
> Thanks for the report. To be sure the issue doesn't fall through the
> cracks unnoticed, I'm adding it to regzbot, the Linux kernel regression
> tracking bot:
> 
> #regzbot ^introduced a837e5161cfffbb32
> #regzbot title meida: venus: firmware: AOSS doesn't seel anymore on at
> least sc7180 and sc7280
> #regzbot ignore-activity
	
#regzbot fix: f95b8ea79c47c0ad
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
That page also explains what to do if mails like this annoy you.