Re: [BUG] staging: rtl8192e: oops occurs when finding hardware rtl8192se

From: Greg Kroah-Hartman
Date: Wed Apr 05 2023 - 10:38:27 EST


On Sun, Apr 02, 2023 at 05:00:13PM +0200, Philipp Hortmann wrote:
> Hi,
>
> when I use the hardware rtl8192se the driver
> drivers/staging/rtl8192e/rtl8192e/r8192e_pci.ko detects that it should not
> run on this hardware and aborts.
> But when the driver is freeing the resources an oops occures. Find oops at
> the end of this Email.
>
> When I comment out the following lines those errors disappear:
> cancel_delayed_work_sync(&ieee->hw_wakeup_wq);
> cancel_delayed_work_sync(&ieee->hw_sleep_wq);
> cancel_work_sync(&ieee->ips_leave_wq);
>
> When I do an init before the cancel:
> INIT_DELAYED_WORK(&priv->rtllib->hw_wakeup_wq, (void *)rtl92e_hw_wakeup_wq);
> The oops are gone as well.
>
> When I use cancel_delayed_work() instead of cancel_delayed_work_sync() it
> also works.
>
> Can somebody give me a hint what the expected way is to solve this?

Is this a new thing, or has it always been there?

Why is the driver loading if you don't have hardware for it? Or are you
manually loading it?

thanks,

greg k-h