Re: [PATCH 5/5] ACPI: Replace irqdomain.h include with struct declarations

From: Rafael J. Wysocki
Date: Wed Apr 05 2023 - 10:59:53 EST


Hi Rob,

On Wed, Mar 29, 2023 at 11:21 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> linux/acpi.h includes irqdomain.h which includes of.h. Break the include
> chain by replacing the irqdomain include with forward declarations for
> struct irq_domain and irq_domain_ops which is sufficient for acpi.h.
>
> Cc: Marc Zyngier <maz@xxxxxxxxxx>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> include/linux/acpi.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index efff750f326d..169c17c0b0dc 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -10,12 +10,14 @@
>
> #include <linux/errno.h>
> #include <linux/ioport.h> /* for struct resource */
> -#include <linux/irqdomain.h>
> #include <linux/resource_ext.h>
> #include <linux/device.h>
> #include <linux/property.h>
> #include <linux/uuid.h>
>
> +struct irq_domain;
> +struct irq_domain_ops;
> +
> #ifndef _LINUX
> #define _LINUX
> #endif
>
> --

This causes build issues in linux-next, so I've dropped the series. I
will be happy to pick it up again when the build issues are addressed,
though.

Thanks!