Re: [PATCH v1 07/14] extcon: Use unique number for the extcon device ID

From: Andy Shevchenko
Date: Wed Apr 05 2023 - 11:04:00 EST


On Mon, Apr 03, 2023 at 11:52:46PM +0900, Chanwoo Choi wrote:
> On 23. 3. 22. 23:39, Andy Shevchenko wrote:

...

> > + ret = ida_simple_get(&extcon_dev_ids, 0, INT_MAX, GFP_KERNEL);
>
>
> ida_simple_get and ida_simple_remove are deprecated on
> commit 3264ceec8f17 ("lib/idr.c: document that ida_simple_{get,remove}()
> are deprecated"). Instead of them, better to use ida_alloc and ida_free
> according to the comments.

Done for v2.

...

> > + ida_simple_remove(&extcon_dev_ids, edev->id);
>
> ditto.

Ditto.

--
With Best Regards,
Andy Shevchenko