Re: [PATCH 1/5] arm64: dts: qcom: sc8280xp: label the Soundwire nodes

[Konrad Dybcio]

On 5.04.2023 08:09, Krzysztof Kozlowski wrote:
> Use labels, instead of comments, for Soundwire controllers.  Naming them
> is useful, because they are specialized and have also naming in
> datasheet/programming guide.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index cd38320dafda..c195a57fd180 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -2497,7 +2497,6 @@ rxmacro: rxmacro@3200000 {
>  			status = "disabled";
>  		};
>  
> -		/* RX */
>  		swr1: soundwire-controller@3210000 {
>  			compatible = "qcom,soundwire-v1.6.0";
>  			reg = <0 0x03210000 0 0x2000>;
> @@ -2572,13 +2571,13 @@ wsamacro: codec@3240000 {
>  			status = "disabled";
>  		};
>  
> -		/* WSA */
>  		swr0: soundwire-controller@3250000 {
>  			reg = <0 0x03250000 0 0x2000>;
>  			compatible = "qcom,soundwire-v1.6.0";
>  			interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&wsamacro>;
>  			clock-names = "iface";
> +			label = "WSA";
>  
>  			qcom,din-ports = <2>;
>  			qcom,dout-ports = <6>;
> @@ -2600,7 +2599,6 @@ swr0: soundwire-controller@3250000 {
>  			status = "disabled";
>  		};
>  
> -		/* TX */
>  		swr2: soundwire-controller@3330000 {
>  			compatible = "qcom,soundwire-v1.6.0";
>  			reg = <0 0x03330000 0 0x2000>;