Re: [PATCH v2 5/6] debugfs: add debugfs_create_atomic64_t for atomic64_t

From: Luis Chamberlain
Date: Wed Apr 05 2023 - 12:12:03 EST


On Wed, Apr 05, 2023 at 09:04:27AM -0700, Luis Chamberlain wrote:
> On Wed, Apr 05, 2023 at 08:26:18AM -0700, Linus Torvalds wrote:
> > So I realize why you use atomic64, but I really suspect you'd be
> > better off with just the regular "atomic_long".
>
> <-- snip -->
>
> > So something like
> >
> > debugfs_create_ulong(... &val->counter ..);
> >
> > instead of
> >
> > debugfs_create_atomic64(... &val ..);
> >
> > Hmm?
>
> We already have debugfs_create_ulong(), it just uses unsigned long
> with no atomic_long. I can just use that then.

Oh but I don't get the atomic incs, so we'd need debugfs_create_atomic_long_t().

Luis