Re: [PATCH v3 21/65] clk: davinci: da8xx-cfgchip: Add a determine_rate hook

From: David Lechner
Date: Wed Apr 05 2023 - 13:58:17 EST


On 4/4/23 5:11 AM, Maxime Ripard wrote:
The Davinci DA8xxx cfgchip mux clock implements a mux with a set_parent
hook, but doesn't provide a determine_rate implementation.

This is a bit odd, since set_parent() is there to, as its name implies,
change the parent of a clock. However, the most likely candidate to
trigger that parent change is a call to clk_set_rate(), with
determine_rate() figuring out which parent is the best suited for a
given rate.


As mentioned in my previous review, parent is selected by device
tree and should never be changed after init.