Re: [PATCH] x86/amd_nb: Check for invalid SMN reads

From: Yazen Ghannam
Date: Wed Apr 05 2023 - 14:33:32 EST


On 4/5/23 14:06, Borislav Petkov wrote:
> On Mon, Apr 03, 2023 at 05:36:40PM -0400, Yazen Ghannam wrote:
>> Yes, that's fine. Should I send another revision?
>
> On a second thought, I think we should do what you said in the write
> function too. Because the write can fail too. So if it can, we need to
> handle that potential error too.
>
> Care to send a new version which does this check in the read and in the
> write function? Basically what you had initially but with the write side
> check added too to amd_smn_write.
>

Sure thing. I don't have a real test for the write path. But I'll test by
faking it.

Thanks,
Yazen