Re: [RESEND PATCH v2] eventfd: use wait_event_interruptible_locked_irq() helper

[Jens Axboe]

On 4/5/23 1:40 PM, Wen Yang wrote:
> 
> 在 2023/4/6 03:26, Jens Axboe 写道:
>> On 4/5/23 1:20 PM, wenyang.linux@xxxxxxxxxxx wrote:
>>> From: Wen Yang <wenyang.linux@xxxxxxxxxxx>
>>>
>>> wait_event_interruptible_locked_irq was introduced by commit 22c43c81a51e
>>> ("wait_event_interruptible_locked() interface"), but older code such as
>>> eventfd_{write,read} still uses the open code implementation.
>>> Inspired by commit 8120a8aadb20
>>> ("fs/timerfd.c: make use of wait_event_interruptible_locked_irq()"), this
>>> patch replaces the open code implementation with a single macro call.
>>>
>>> No functional change intended.
>> Looks pretty reasonable to me. How did you test it?
>>
> Thanks.
> 
> We have verified it in some local testing environments, and the intel-lab-lkp has also tested it more than a month, as follows:
> 
> https://github.com/intel-lab-lkp/linux/tree/wenyang-linux-foxmail-com/eventfd-use-wait_event_interruptible_locked_irq-helper/20230217-023039

Nice, you can add my:

Reviewed-by: Jens Axboe <axboe@xxxxxxxxx>

to it as well. Adding Christian as well, as I guess this should go
through his/al/vfs tree.

-- 
Jens Axboe