Re: linux-next: Fixes tag needs some work in the rcu tree

From: Paul E. McKenney
Date: Wed Apr 05 2023 - 18:59:44 EST


On Thu, Apr 06, 2023 at 08:36:19AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> acdc79917d65 ("rcu/kvfree: Avoid freeing new kfree_rcu() memory after old grace period")
>
> Fixes tag
>
> Fixes: 0392bebebf26 ("rcu/kvfree: Avoid freeing new kfree_rcu() memory after old grace period")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> Maybe you meant:
>
> Fixes: 0392bebebf26 ("rcu: Add multiple in-flight batches of kfree_rcu() work")

Hello, Stephen,

There is currently some debate as to exactly which commit(s) introduced
the bug, which will hopefully come to a conclusion before tomorrow's
-next. If they do not, I will use your correction as a placeholder.

Just for completeness, the current other two candidates (which appear
quite plausible to me) are these:

Fixes: 34c881745549 ("rcu: Support kfree_bulk() interface in kfree_rcu()")
Fixes: 5f3c8d620447 ("rcu/tree: Maintain separate array for vmalloc ptrs")

Ziwei Dai, what are your thoughts on this? This is from a mainline
perspective, my guess being that your investigation involved some other
Linux-kernel tree.

Thanx, Paul