RE: [PATCH v1 00/14] extcon: Core cleanups and documentation fixes

From: Bumwoo Lee
Date: Wed Apr 05 2023 - 20:05:26 EST


Hi

> -----Original Message-----
> From: Chanwoo Choi <cwchoi00@xxxxxxxxx>
> Sent: Thursday, April 6, 2023 8:17 AM
> To: Bumwoo Lee <bw365.lee@xxxxxxxxxxx>; 'Andy Shevchenko'
> <andriy.shevchenko@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Cc: 'MyungJoo Ham' <myungjoo.ham@xxxxxxxxxxx>; 'Chanwoo Choi'
> <cw00.choi@xxxxxxxxxxx>
> Subject: Re: [PATCH v1 00/14] extcon: Core cleanups and documentation
> fixes
>
> Hi,
>
> On 23. 3. 31. 09:48, Bumwoo Lee wrote:
> > Hi Andy Shevchenko
> >> -----Original Message-----
> >> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >> Sent: Thursday, March 30, 2023 7:12 PM
> >> To: Bumwoo Lee <bw365.lee@xxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> >> Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>; Chanwoo Choi
> >> <cw00.choi@xxxxxxxxxxx>
> >> Subject: Re: [PATCH v1 00/14] extcon: Core cleanups and documentation
> >> fixes
> >>
> >> On Wed, Mar 22, 2023 at 04:39:51PM +0200, Andy Shevchenko wrote:
> >>> A few fixes to the documentation and some cleanups against extcon
> >>> core module.
> >>
> >> Anything I should do with the series?
> >> Any comments on it?
> >>
> >> --
> >> With Best Regards,
> >> Andy Shevchenko
> >>
> >
> > Looks fine to me.
> >
> > Acked-by: Bumwoo Lee <bw365.lee@xxxxxxxxxxx>
> >
> > MR. Chanwoo, Would you please take a look at this patch series.
> >
>
> Actually, Acked tag will be replied by Maintainer or the driver owner.
> If you want to review the mailing list patch, I think that Reviewed-by tag
> is proper.
>

OK.
Thank you for your detail guidance. I will follow this guidance on next time.

> Unfortunately, I could not see the any review comment from you even if
> this patchset have the some review contents. Also you didn't review the
> any patches of extcon before.
>
> I'm always welcome for many reviewers in order to improve the linux kernel.
> But, in this case, I'm not sure that you are reviewing this patchset.
>
> So that I'm sorry that I cannot take your acked-tag.
>

I agree your comment.
Thank you~

> --
> Best Regards,
> Samsung Electronics
> Chanwoo Choi