Re: [PATCH v3 0/3] Move Loongson1 PWM timer to clocksource framework

[Keguang Zhang]

On Thu, Mar 30, 2023 at 9:24 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Thu, Mar 30, 2023 at 07:05:09PM +0800, Keguang Zhang wrote:
> > Move Loongson1 PWM timer to clocksource framework
> > and update the Kconfig/Makefile options accordingly.
>
> Why?
>
Sorry for the late reply.
The clocksource driver should go to the clocksource framework, right?
The current implementation is outdated.

> What does this have to do with the binding? Did the h/w change? No.
>
No h/w change.
The clocksource driver needs DT support.
Maybe my description is not clear enough.

> >
> > Changelog
> > V2 -> V3: Remove the reference to regs-pwm.h
> > V1 -> V2: Delete the obsolete header file regs-pwm.h
> >
> > Keguang Zhang (3):
> >   MIPS: Loongson32: Remove deprecated PWM timer clocksource
> >   dt-bindings: timer: Add Loongson-1 clocksource
> >   clocksource: loongson1: Move PWM timer to clocksource framework
> >
> >  .../timer/loongson,ls1x-pwmtimer.yaml         |  48 ++++
> >  .../include/asm/mach-loongson32/loongson1.h   |   1 -
> >  .../include/asm/mach-loongson32/regs-pwm.h    |  25 --
> >  arch/mips/loongson32/Kconfig                  |  37 ---
> >  arch/mips/loongson32/common/time.c            | 210 ----------------
> >  drivers/clocksource/Kconfig                   |   9 +
> >  drivers/clocksource/Makefile                  |   1 +
> >  drivers/clocksource/timer-loongson1-pwm.c     | 236 ++++++++++++++++++
> >  8 files changed, 294 insertions(+), 273 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/timer/loongson,ls1x-pwmtimer.yaml
> >  delete mode 100644 arch/mips/include/asm/mach-loongson32/regs-pwm.h
> >  create mode 100644 drivers/clocksource/timer-loongson1-pwm.c
> >
> >
> > base-commit: f7b5a248213f0976c7944925f3f3ab7ff199e581
> > --
> > 2.34.1
> >



-- 
Best regards,

Keguang Zhang