Re: [PATCH v2 0/3] lib/string_helpers et al.: Change return value of strreplace()

[Kees Cook]

On April 5, 2023 7:38:40 AM PDT, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>On Wed, Apr 05, 2023 at 04:24:42PM +0200, Greg Kroah-Hartman wrote:
>> On Wed, Apr 05, 2023 at 04:34:31PM +0300, Andy Shevchenko wrote:
>> > On Thu, Mar 23, 2023 at 02:37:01PM +0200, Andy Shevchenko wrote:
>> > > It's more convenient to have strreplace() to return the pointer to
>> > >  the string itself. This will help users to make their code better.
>> > > 
>> > > The patch 1 kills the only user of the returned value of strreplace(),
>> > > Patch 2 converts the return value of strreplace(). And patch 3 shows
>> > > how it may be useful. That said, the series can be routed via fs tree,
>> > > with or without the last patch.
>> > 
>> > Since there are no comments, who can apply this (patches 1 and 2)?
>> > Greg, are you fine with the kobject change?
>> 
>> Sure, want me to take them all through my driver-core tree?
>
>Fine by me! Dunno about others. Kees?

Yeah, that's cool by me. :)


-- 
Kees Cook