RE: [PATCH 2/9] tty: n_gsm: add restart parameter to DLC specific ioctl config

From: Starke, Daniel
Date: Thu Apr 06 2023 - 01:18:00 EST


> > From: Daniel Starke <daniel.starke@xxxxxxxxxxx>
> >
> > 'gsm_config_ext' already allows to force a link reset via 'restart'
> > parameter.
>
> Please be more precise, there a function and struct with this name.
>
> HOWEVER, there is no such parameter in tty-next (am I looking from wrong
> repo??):
>
> static int gsm_config_ext(struct gsm_mux *gsm, struct gsm_config_ext *ce)
>
> ...nor here:
>
> struct gsm_config_ext {
> __u32 keep_alive; /* Control channel keep-alive in 1/100th of a
> * second (0 to disable)
> */
> __u32 wait_config; /* Wait for DLCI config before opening virtual link? */
> __u32 reserved[6]; /* For future use, must be initialized to zero */
> };
>
> ???

You are right. Looks like I was looking at the wrong branch. I will reword
the commit message and deliver the patch for 'struct gsm_config_ext'
afterwards.

Best regards,
Daniel Starke