RE: [PATCH 3/9] tty: n_gsm: add missing description to gsm_config

From: Starke, Daniel
Date: Thu Apr 06 2023 - 01:26:10 EST


> > + unsigned int mru; /* Maximum incoming frame payload size */
> > + unsigned int mtu; /* Maximum outgoing frame payload size */
>
> I'm used to "payload" referring in networking context to "useful" part of
> the frame but MTU/MRU probably includes headers too? Maybe just say
> "frame size"?

Just frame size is incorrect, as the basic/advanced option mode header and
byte stuffing do not count against this number. See 'gsm0_receive' and
'gsm1_receive' and also ch. 5.7.2 of the standard. The outgoing limit is
applied in 'gsm_dlci_data_output' and 'gsm_dlci_data_output_framed'.

Link: https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=1516

Best regards,
Daniel Starke