RE: [PATCH 8/9] tty: n_gsm: add DLCI specific rx/tx statistics

From: Starke, Daniel
Date: Thu Apr 06 2023 - 02:02:35 EST


> > @@ -1215,6 +1218,7 @@ static int gsm_dlci_data_output(struct gsm_mux *gsm, struct gsm_dlci *dlci)
> > tty_port_tty_wakeup(&dlci->port);
> >
> > __gsm_data_queue(dlci, msg);
> > + dlci->tx += len;
> > /* Bytes of data we used up */
> > return size;
> > }
>
> Reading the function comments and your changelog, I'm left to wonder why
> gsm_dlci_data_output() is supposed to increment ->tx but
> gsm_dlci_data_output_framed() is not?

Thank you for pointing this out. I will add the part for
gsm_dlci_data_output_framed() it in the next version of this patch.

Best regards,
Daniel Starke