Re: [PATCH v2 2/2] dt-bindings: cisco: document the CrayAR compatibles

From: Krzysztof Kozlowski
Date: Thu Apr 06 2023 - 03:12:46 EST


On 06/04/2023 00:30, Daniel Walker wrote:
> Describe the compatible properties for the Cisco CrayAR SoC.
>
> Cc: xe-linux-external@xxxxxxxxx
> Cc: Marcin Wierzbicki <mawierzb@xxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>

Please drop the autogenerated scripts/get_maintainer.pl CC-entries from
commit msg. There is no single need to store automated output of
get_maintainers.pl in the git log. It can be easily re-created at any
given time, thus its presence in the git history is redundant and
obfuscates the log.

If you need it for your own patch management purposes, keep it under the
--- separator.

> Signed-off-by: Daniel Walker <dwalker@xxxxxxxxxx>
> ---
> .../devicetree/bindings/arm/cisco/crayar.yaml | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/cisco/crayar.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/cisco/crayar.yaml b/Documentation/devicetree/bindings/arm/cisco/crayar.yaml
> new file mode 100644
> index 000000000000..0ee4e6313ab0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/cisco/crayar.yaml

How many (or not many) platforms do you expect from Cisco? We mostly
have one file per SoC manufacturer.

> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: GPL-2.0-only

Dual license.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/cisco/crayar.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cisco CrayAR based Platforms
> +

Best regards,
Krzysztof