Re: [PATCH v6 2/2] leds: lp55xx: configure internal charge pump

[Maarten Zanders]

> Sorry Maarten, just a couple of small nits.

No need to be sorry.


> This fits on one line, no?  < 100-chars?

I thought the line length was meant to be <80 chars according to:

https://www.kernel.org/doc/html/latest/process/coding-style.html#breaking-long-lines-and-strings

Happy to adapt if this shouldn't be taken as strict as I tried to do. 
Either way I'll post an update with a cleanup.

> > --- a/include/linux/platform_data/leds-lp55xx.h
> > +++ b/include/linux/platform_data/leds-lp55xx.h
> > @@ -73,6 +73,9 @@ struct lp55xx_platform_data {
> >   	/* Clock configuration */
> >   	u8 clock_mode;
> >
> > +	/* Charge pump mode */
> > +	u32 charge_pump_mode;
> That's a lot of data.  Does it need to be u32?

No, it luckily doesn't get that big. This is to avoid an intermediate 
variable & casting as the DT parameter has to be 32bit (which I learned 
from an earlier comment). It was changed from u8 in v5 of the patch.

Thanks for the review,
Maarten