Re: [PATCH 2/7] dt-bindings: net: dsa: mediatek,mt7530: improve MCM and MT7988 information

[Daniel Golle]

On Thu, Apr 06, 2023 at 11:01:36AM +0300, arinc9.unal@xxxxxxxxx wrote:
> From: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> 
> Improve the description of the schema.
> 
> The MT7620 SoCs described are not part of the multi-chip module but rather
> built into the SoC. Mention the MT7530 MMIO driver not supporting them.
> 
> Move information for the switch on the MT7988 SoC below MT7531, and improve
> it.
> 
> List maintainers in alphabetical order by first name.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>

Acked-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>

> ---
>  .../bindings/net/dsa/mediatek,mt7530.yaml     | 25 ++++++++++---------
>  1 file changed, 13 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> index 6df995478275..7045a98d9593 100644
> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> @@ -8,29 +8,30 @@ title: MediaTek MT7530 and MT7531 Ethernet Switches
>  
>  maintainers:
>    - Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> +  - Daniel Golle <daniel@xxxxxxxxxxxxxx>
>    - Landen Chao <Landen.Chao@xxxxxxxxxxxx>
>    - DENG Qingfang <dqfext@xxxxxxxxx>
>    - Sean Wang <sean.wang@xxxxxxxxxxxx>
> -  - Daniel Golle <daniel@xxxxxxxxxxxxxx>
>  
>  description: |
> -  There are three versions of MT7530, standalone, in a multi-chip module and
> -  built-into a SoC.
> +  There are three versions of MT7530, standalone, in a multi-chip module, and
> +  built into an SoC.
>  
> -  MT7530 is a part of the multi-chip module in MT7620AN, MT7620DA, MT7620DAN,
> -  MT7620NN, MT7621AT, MT7621DAT, MT7621ST and MT7623AI SoCs.
> -
> -  The MT7988 SoC comes with a built-in switch similar to MT7531 as well as four
> -  Gigabit Ethernet PHYs. The switch registers are directly mapped into the SoC's
> -  memory map rather than using MDIO. The switch got an internally connected 10G
> -  CPU port and 4 user ports connected to the built-in Gigabit Ethernet PHYs.
> +  MT7530 is a part of the multi-chip module in MT7621AT, MT7621DAT, MT7621ST and
> +  MT7623AI SoCs.
>  
>    MT7530 in MT7620AN, MT7620DA, MT7620DAN and MT7620NN SoCs has got 10/100 PHYs
> -  and the switch registers are directly mapped into SoC's memory map rather than
> -  using MDIO. The DSA driver currently doesn't support MT7620 variants.
> +  and the switch registers are directly mapped into the SoC's memory map rather
> +  than using MDIO. The MT7530 MMIO driver currently doesn't support these SoCs.
>  
>    There is only the standalone version of MT7531.
>  
> +  The MT7988 SoC comes with a built-in switch with four Gigabit Ethernet PHYs.
> +  The characteristics of the switch is similar to MT7531. The switch registers
> +  are directly mapped into the SoC's memory map rather than using MDIO. The
> +  switch has got an internally connected 10G CPU port and 4 user ports connected
> +  to the built-in Gigabit Ethernet PHYs.
> +
>    Port 5 on MT7530 has got various ways of configuration:
>  
>      - Port 5 can be used as a CPU port.
> -- 
> 2.37.2
>