Re: [PATCH 8/8] regulator: fan53555: Add support for RK860X

From: Krzysztof Kozlowski
Date: Thu Apr 06 2023 - 07:03:55 EST


On 06/04/2023 12:08, Cristian Ciocaltea wrote:
>>> + }, {
>>> + .name = "rk8602",
>>> + .driver_data = RK8602_VENDOR_ROCKCHIP
>>> + }, {
>>> + .name = "rk8603",
>>> + .driver_data = RK8602_VENDOR_ROCKCHIP
>>
>> Why do you need this entry match data if it is the same as rk8602?
>
> This is consistent with the handling of syr827 and syr828:
>
> .name = "syr827",
> .driver_data = FAN53555_VENDOR_SILERGY
> }, {
> .name = "syr828",
> .driver_data = FAN53555_VENDOR_SILERGY

Yeah, I understand, but it's not necessarily the pattern we want to
continue. Unless these devices are not really compatible?

Best regards,
Krzysztof