Re: [PATCH net-next v3 04/14] sfc: evaluate vdpa support based on FW capability CLIENT_CMD_VF_PROXY
From: kernel test robot
Date: Thu Apr 06 2023 - 09:38:07 EST
Hi Gautam,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Gautam-Dawar/sfc-add-function-personality-support-for-EF100-devices/20230406-151436
patch link: https://lore.kernel.org/r/20230406065706.59664-5-gautam.dawar%40amd.com
patch subject: [PATCH net-next v3 04/14] sfc: evaluate vdpa support based on FW capability CLIENT_CMD_VF_PROXY
config: openrisc-randconfig-r025-20230403 (https://download.01.org/0day-ci/archive/20230406/202304062157.jUftzJPl-lkp@xxxxxxxxx/config)
compiler: or1k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/1648cc5a817ed0b133554de429e9516dfdc18ddf
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Gautam-Dawar/sfc-add-function-personality-support-for-EF100-devices/20230406-151436
git checkout 1648cc5a817ed0b133554de429e9516dfdc18ddf
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/net/ethernet/sfc/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202304062157.jUftzJPl-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
drivers/net/ethernet/sfc/ef100_nic.c: In function 'efx_ef100_init_datapath_caps':
>> drivers/net/ethernet/sfc/ef100_nic.c:211:25: error: 'struct ef100_nic_data' has no member named 'vdpa_supported'
211 | nic_data->vdpa_supported = efx->type->is_vf &&
| ^~
vim +211 drivers/net/ethernet/sfc/ef100_nic.c
164
165 static int efx_ef100_init_datapath_caps(struct efx_nic *efx)
166 {
167 MCDI_DECLARE_BUF(outbuf, MC_CMD_GET_CAPABILITIES_V7_OUT_LEN);
168 struct ef100_nic_data *nic_data = efx->nic_data;
169 u8 vi_window_mode;
170 size_t outlen;
171 int rc;
172
173 BUILD_BUG_ON(MC_CMD_GET_CAPABILITIES_IN_LEN != 0);
174
175 rc = efx_mcdi_rpc(efx, MC_CMD_GET_CAPABILITIES, NULL, 0,
176 outbuf, sizeof(outbuf), &outlen);
177 if (rc)
178 return rc;
179 if (outlen < MC_CMD_GET_CAPABILITIES_V4_OUT_LEN) {
180 netif_err(efx, drv, efx->net_dev,
181 "unable to read datapath firmware capabilities\n");
182 return -EIO;
183 }
184
185 nic_data->datapath_caps = MCDI_DWORD(outbuf,
186 GET_CAPABILITIES_OUT_FLAGS1);
187 nic_data->datapath_caps2 = MCDI_DWORD(outbuf,
188 GET_CAPABILITIES_V2_OUT_FLAGS2);
189 if (outlen < MC_CMD_GET_CAPABILITIES_V7_OUT_LEN)
190 nic_data->datapath_caps3 = 0;
191 else
192 nic_data->datapath_caps3 = MCDI_DWORD(outbuf,
193 GET_CAPABILITIES_V7_OUT_FLAGS3);
194
195 vi_window_mode = MCDI_BYTE(outbuf,
196 GET_CAPABILITIES_V3_OUT_VI_WINDOW_MODE);
197 rc = efx_mcdi_window_mode_to_stride(efx, vi_window_mode);
198 if (rc)
199 return rc;
200
201 efx->num_mac_stats = MCDI_WORD(outbuf,
202 GET_CAPABILITIES_V4_OUT_MAC_STATS_NUM_STATS);
203 netif_dbg(efx, probe, efx->net_dev,
204 "firmware reports num_mac_stats = %u\n",
205 efx->num_mac_stats);
206
207 /* Current EF100 hardware supports vDPA on VFs only, requires MCDI v2
208 * and Firmware's capability to proxy MCDI commands from PF to VF
209 */
210 if (IS_ENABLED(CONFIG_SFC_VDPA)) {
> 211 nic_data->vdpa_supported = efx->type->is_vf &&
212 (efx->type->mcdi_max_ver > 1) &&
213 efx_ef100_has_cap(nic_data->datapath_caps3,
214 CLIENT_CMD_VF_PROXY);
215 }
216
217 return 0;
218 }
219
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests