Re: [PATCH net-next v3 06/14] sfc: implement vDPA management device operations

From: kernel test robot
Date: Thu Apr 06 2023 - 11:08:05 EST


Hi Gautam,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url: https://github.com/intel-lab-lkp/linux/commits/Gautam-Dawar/sfc-add-function-personality-support-for-EF100-devices/20230406-151436
patch link: https://lore.kernel.org/r/20230406065706.59664-7-gautam.dawar%40amd.com
patch subject: [PATCH net-next v3 06/14] sfc: implement vDPA management device operations
config: openrisc-randconfig-r025-20230403 (https://download.01.org/0day-ci/archive/20230406/202304062229.feOqJmLW-lkp@xxxxxxxxx/config)
compiler: or1k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/0887a40c60d1983214d417491dc9ef46191ab1ac
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Gautam-Dawar/sfc-add-function-personality-support-for-EF100-devices/20230406-151436
git checkout 0887a40c60d1983214d417491dc9ef46191ab1ac
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/net/ethernet/sfc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202304062229.feOqJmLW-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

drivers/net/ethernet/sfc/ef100_nic.c: In function 'efx_ef100_init_datapath_caps':
drivers/net/ethernet/sfc/ef100_nic.c:214:25: error: 'struct ef100_nic_data' has no member named 'vdpa_supported'
214 | nic_data->vdpa_supported = efx->type->is_vf &&
| ^~
drivers/net/ethernet/sfc/ef100_nic.c: In function 'ef100_probe_vf':
drivers/net/ethernet/sfc/ef100_nic.c:1300:29: error: 'struct ef100_nic_data' has no member named 'vdpa_supported'
1300 | if (nic_data->vdpa_supported) {
| ^~
>> drivers/net/ethernet/sfc/ef100_nic.c:1301:31: error: implicit declaration of function 'ef100_vdpa_register_mgmtdev' [-Werror=implicit-function-declaration]
1301 | err = ef100_vdpa_register_mgmtdev(efx);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/sfc/ef100_nic.c: In function 'ef100_remove':
drivers/net/ethernet/sfc/ef100_nic.c:1316:52: error: 'struct ef100_nic_data' has no member named 'vdpa_supported'
1316 | if (IS_ENABLED(CONFIG_SFC_VDPA) && nic_data->vdpa_supported)
| ^~
>> drivers/net/ethernet/sfc/ef100_nic.c:1317:17: error: implicit declaration of function 'ef100_vdpa_unregister_mgmtdev' [-Werror=implicit-function-declaration]
1317 | ef100_vdpa_unregister_mgmtdev(efx);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors


vim +/ef100_vdpa_register_mgmtdev +1301 drivers/net/ethernet/sfc/ef100_nic.c

1287
1288 int ef100_probe_vf(struct efx_nic *efx)
1289 {
1290 struct ef100_nic_data *nic_data __maybe_unused;
1291 int err __maybe_unused;
1292 int rc;
1293
1294 rc = ef100_probe_main(efx);
1295 if (rc)
1296 return rc;
1297
1298 if (IS_ENABLED(CONFIG_SFC_VDPA)) {
1299 nic_data = efx->nic_data;
1300 if (nic_data->vdpa_supported) {
> 1301 err = ef100_vdpa_register_mgmtdev(efx);
1302 if (err)
1303 pci_warn(efx->pci_dev,
1304 "register_mgmtdev failed, rc: %d\n",
1305 err);
1306 }
1307 }
1308
1309 return 0;
1310 }
1311
1312 void ef100_remove(struct efx_nic *efx)
1313 {
1314 struct ef100_nic_data *nic_data = efx->nic_data;
1315
1316 if (IS_ENABLED(CONFIG_SFC_VDPA) && nic_data->vdpa_supported)
> 1317 ef100_vdpa_unregister_mgmtdev(efx);
1318
1319 if (IS_ENABLED(CONFIG_SFC_SRIOV) && efx->mae) {
1320 efx_ef100_fini_reps(efx);
1321 efx_fini_mae(efx);
1322 }
1323
1324 efx_mcdi_detach(efx);
1325 efx_mcdi_fini(efx);
1326 if (nic_data) {
1327 efx_nic_free_buffer(efx, &nic_data->mcdi_buf);
1328 mutex_destroy(&nic_data->bar_config_lock);
1329 }
1330 kfree(nic_data);
1331 efx->nic_data = NULL;
1332 }
1333

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests