Re: [PATCH v2] mm: oom: introduce cpuset oom

From: Waiman Long
Date: Thu Apr 06 2023 - 11:54:24 EST



On 4/6/23 09:02, Gang Li wrote:
On 2023/4/5 01:24, Waiman Long wrote:

You will also need to take cpuset_rwsem to make sure that cpusets are stable. BTW, the cpuset_cgroup_scan_tasks() name is kind of redundant. I will suggest you just name it as cpuset_scan_tasks(). Please also add a

mem cgroup oom use `mem_cgroup_scan_tasks`.
How about keep `cpuset_cgroup_scan_tasks` for naming consistency?

The "memory cgroup" term is used to identify the code related to memory cgroup controller. Cpuset, on the other hand, is a well known cgroup controller. Cpuset cgroup is not a term that people will normally use.  That is why this name is awkward.

Cheers,
Longman