Re: [PATCH] ASoC: dt-bindings: wm8523: Convert to dtschema
From: Krzysztof Kozlowski
Date: Thu Apr 06 2023 - 13:38:26 EST
On 05/04/2023 22:34, Saalim Quadri wrote:
> Convert the WM8523 audio CODEC bindings to DT schema
>
> Signed-off-by: Saalim Quadri <danascape@xxxxxxxxx>
> ---
> .../devicetree/bindings/sound/wlf,wm8523.yaml | 40 +++++++++++++++++++
> .../devicetree/bindings/sound/wm8523.txt | 16 --------
> 2 files changed, 40 insertions(+), 16 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8523.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/wm8523.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8523.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8523.yaml
> new file mode 100644
> index 000000000000..decc395bb873
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/wlf,wm8523.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/wlf,wm8523.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: WM8523 audio CODEC
> +
> +maintainers:
> + - patches@xxxxxxxxxxxxxxxxxxxxx
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +properties:
> + compatible:
> + const: wlf,wm8523
> +
> + reg:
> + maxItems: 1
> +
> + "#sound-dai-cells":
> + const: 0
> +
Please squash all your three WM bindings (wm8711, wm8580 and wm8523)
into one binding, if they are the same. Probably other WM from your
previous submissions as well. We really do not need binding per each of
this simple codecs. If they ever need to grow, then we can split them.
Best regards,
Krzysztof