Re: [PATCH v3 1/2] dt-bindings: net: Convert ATH10K to YAML

From: Konrad Dybcio
Date: Thu Apr 06 2023 - 14:39:33 EST




On 6.04.2023 20:30, Krzysztof Kozlowski wrote:
> On 06/04/2023 20:26, Konrad Dybcio wrote:
>
>>>> + interrupts:
>>>> + items:
>>>> + - description: CE0
>>>> + - description: CE1
>>>> + - description: CE2
>>>> + - description: CE3
>>>> + - description: CE4
>>>> + - description: CE5
>>>> + - description: CE6
>>>> + - description: CE7
>>>> + - description: CE8
>>>> + - description: CE9
>>>> + - description: CE10
>>>> + - description: CE11
>>>
>>> What about interrupt-names here? If they are not expected, then just
>>> interrupt-names: false
>> They obviously wouldn't hurt, but they're unused on the driver side:
>>
>> for (i = 0; i < CE_COUNT; i++) {
>> ret = platform_get_irq(ar_snoc->dev, i);
>>
>> So I will forbid them.
>
> Assuming DTS does not have them.
Tested locally, no warnings, so looks like nobody used them in dt.

Konrad
>
> Best regards,
> Krzysztof
>