Re: [PATCH 2/3] iio: pressure: Honeywell mpr pressure sensor

From: Andreas Klinger
Date: Thu Apr 06 2023 - 15:44:28 EST


Hi Jonathan,

thanks for the extensive review. Most of it is clear but one questions remain.
See below.

Jonathan Cameron <jic23@xxxxxxxxxx> schrieb am Sa, 01. Apr 18:57:
> > +static void mpr_reset(struct mpr_data *data)
> > +{
> > + if (data->gpiod_reset) {
> > + gpiod_set_value(data->gpiod_reset, 0);
> > + udelay(10);
> > + gpiod_set_value(data->gpiod_reset, 1);
> > + }
>
> If there isn't a reset signal, I'd like to see an attempt at least to write
> all configuration registers to a known value (same as the one you'd
> get after reset).

There is no configuration register in the sensor I could write to. But maybe I
didn't comprehend your point.

Andreas