RE: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

[Christoph Niedermaier]

From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx]
Sent: Thursday, April 6, 2023 8:00 PM
> On 06/04/2023 19:54, Christoph Niedermaier wrote:
> 
>>>> +++ b/arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts
>>>> @@ -0,0 +1,361 @@
>>>> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
>>>> +/*
>>>> + * Copyright (C) 2023 DH electronics GmbH
>>>> + * Copyright (C) 2023 Marantec electronics GmbH
>>>> + *
>>>> + * DHCOM iMX6ULL variant:
>>>> + * DHCR-iMX6ULL-C080-R051-SPI-WBT-I-01LG
>>>> + * DHCOR PCB number: 578-200 or newer
>>>> + * maveo box PCB number: 525-200 or newer
>>>> + */
>>>> +
>>>> +/dts-v1/;
>>>> +
>>>> +#include "imx6ull-dhcor-som.dtsi"
>>>> +
>>>> +/ {
>>>> +     model = "DH electronics i.MX6ULL DHCOR on maveo box";
>>>> +     compatible = "marantec,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som",
>>>> +                  "fsl,imx6ull";
>>>> +
>>>> +     aliases {
>>>> +             /delete-property/ mmc0; /* Avoid double definitions */
>>>
>>> I don't understand it. What is "double definition" of aliases?
>>
>> Otherwise I end up like this:
>> mmc0 = &usdhc1;
>> mmc1 = &usdhc2;
>> mmc2 = &usdhc2;
>>
>> Is "Ensure unique allocation" a better comment here?
>>
>>>
>>>> +             /delete-property/ mmc1;
>>>> +             mmc2 = &usdhc2; /* eMMC should be mmc2 */
>>>
>>> Why? How is this labeled on the board (physically or on schematics)? If
>>> you answer here "for booting", then the answer is NAK. Don't add
>>> software policies to Devicetree.
>>
>> The name in the schematics is "SD2".
> 
> Answering also to above - then likely the aliases should be dropped from
> SoM. I doubt that Som calls it SD1 and your board SD2...

Maybe I don't quite get it, but the hardware starts counting at 1. The first
interface is SD1 and it is used as WiFi. The second one is SD2 which is the
eMMC. So with this aliases it should match SD2 to mmc2.
Do you want me to delete the aliases in the include file "imx6ull-dhcor-som.dtsi"
or what can I do?


Thanks and regards
Christoph