Re: [PATCH v3 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx

From: Krzysztof Kozlowski
Date: Fri Apr 07 2023 - 02:54:18 EST


On 07/04/2023 08:51, Changhuang Liang wrote:
>>> +
>>> + resets:
>>> + items:
>>> + - description: DPHY_HW reset
>>> + - description: DPHY_B09_ALWAYS_ON reset
>>> +
>>> + starfive,aon-syscon:
>>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>>> + items:
>>> + - items:
>>> + - description: phandle of AON SYSCON
>>> + - description: register offset
>>> + description: The power of dphy rx is configured by AON SYSCON
>>> + in this property.
>>
>> Sounds like AON SYSCON should be a power-domains provider. Custom
>> phandle links are for things which don't fit standard bindings.
>>
>
> Hi, Rob,
>
> On visionfive2 jh7110 SoC, this AON SYSCON is the Secondary power switch to the DPHY Rx.
> When we open the pmic switch, we also need to configure the AON SYSCON register to turn
> on the switch, it is used to link the pmic and the DPHY Rx, So I think it just use syscon
> framework is enought. What about your comments.

Which sounds exactly like power domain provider...

Best regards,
Krzysztof