Re: [PATCH] niu: Fix missing unwind goto in niu_alloc_channels()

From: patchwork-bot+netdevbpf
Date: Fri Apr 07 2023 - 03:20:33 EST


Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@xxxxxxxxxxxxx>:

On Wed, 5 Apr 2023 23:31:18 -0700 you wrote:
> Smatch reports: drivers/net/ethernet/sun/niu.c:4525
> niu_alloc_channels() warn: missing unwind goto?
>
> If niu_rbr_fill() fails, then we are directly returning 'err' without
> freeing the channels.
>
> Fix this by changing direct return to a goto 'out_err'.
>
> [...]

Here is the summary with links:
- niu: Fix missing unwind goto in niu_alloc_channels()
https://git.kernel.org/netdev/net/c/8ce07be70345

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html