Re: [PATCH] fuse: remove unnecessary goto

From: Nitesh Shetty
Date: Fri Apr 07 2023 - 04:29:13 EST


On 23/04/07 03:56AM, Yangtao Li wrote:
In this case, the error code can be returned directly.

Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>
---
fs/fuse/inode.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index d66070af145d..56efcf160513 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -1921,10 +1921,8 @@ static int fuse_sysfs_init(void)
int err;

fuse_kobj = kobject_create_and_add("fuse", fs_kobj);
- if (!fuse_kobj) {
- err = -ENOMEM;
- goto out_err;
- }
+ if (!fuse_kobj)
+ return -ENOMEM;

err = sysfs_create_mount_point(fuse_kobj, "connections");
if (err)
@@ -1934,7 +1932,6 @@ static int fuse_sysfs_init(void)

out_fuse_unregister:
kobject_put(fuse_kobj);
- out_err:
return err;
}

--
2.35.1

Reviewed by: Nitesh Shetty <nj.shetty@xxxxxxxxxxx>