Re: [PATCH v3 1/2] test_firmware: Fix some racing conditions in test_fw_config locking.

[Dan Carpenter]

On Fri, Apr 07, 2023 at 10:24:24AM +0200, Mirsad Goran Todorovac wrote:
> 
> Hi Mr. Carpenter,
> 
> Thank you for your review.
> 
> I will proceed according to your guidelines and issue the next version of the
> patch set.
> 
> But I cannot promise it will be before the holidays - I do not want to make
> the gods angry either ;-)
> 

There is never a rush.

> I cannot promise to try smart macros or inline functions with smart function
> parameters just yet.
> 

Don't worry about that.  It just seemed like you were working towards
a more general purpose infrastructure.  It's just a clean up.

> I would consider the real success if I hunt down the remaining leak and races
> in this driver. Despite being considered a less important one.
> 
> As you have previously asserted, it is not a real security issue with a CVE,
> however, for completeness sake I would like to see these problems fixed.

That's great.  If you get bored and feel like giving up then just send
PATCH 2/2 by itself because that one could be merged as is.

regards,
dan carpenter