Re: [PATCH] ufs: hwmon: constify pointers to hwmon_channel_info
From: Krzysztof Kozlowski
Date: Fri Apr 07 2023 - 14:53:26 EST
On 07/04/2023 20:30, Bart Van Assche wrote:
> On 4/7/23 08:01, Krzysztof Kozlowski wrote:
>> -static const struct hwmon_channel_info *ufs_hwmon_info[] = {
>> +static const struct hwmon_channel_info * const ufs_hwmon_info[] = {
>> HWMON_CHANNEL_INFO(temp, HWMON_T_ENABLE | HWMON_T_INPUT | HWMON_T_CRIT | HWMON_T_LCRIT),
>> NULL
>> };
>
> A nit: to me the use of whitespace in this patch does not seem to be
> compliant with the Linux kernel coding style.
You mean it should be:
hwmon_channel_info *const ufs_hwmon_info
?
I think the pointer * is tied only to variable name, but not to const.
Majority seems to choose similarly:
git grep "\*const" | wc -l
2763
git grep "\* const" | wc -l
16204
But if this is more than a nit, but your preference, I can fix it.
Best regards,
Krzysztof