Re: [PATCH] power: supply: hwmon: constify pointers to hwmon_channel_info

From: Sebastian Reichel
Date: Fri Apr 07 2023 - 18:12:59 EST


Hi,

On Fri, Apr 07, 2023 at 05:03:26PM +0200, Krzysztof Kozlowski wrote:
> Statically allocated array of pointed to hwmon_channel_info can be
> made const for safety.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> This depends on hwmon core patch:
> https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@xxxxxxxxxx/
>
> Therefore I propose this should also go via hwmon tree.
>
> Cc: Jean Delvare <jdelvare@xxxxxxxx>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: linux-hwmon@xxxxxxxxxxxxxxx
> ---

Acked-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>

-- Sebastian

> drivers/power/supply/power_supply_hwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/power_supply_hwmon.c b/drivers/power/supply/power_supply_hwmon.c
> index a48aa4afb828..c97893d4c25e 100644
> --- a/drivers/power/supply/power_supply_hwmon.c
> +++ b/drivers/power/supply/power_supply_hwmon.c
> @@ -293,7 +293,7 @@ static const struct hwmon_ops power_supply_hwmon_ops = {
> .read_string = power_supply_hwmon_read_string,
> };
>
> -static const struct hwmon_channel_info *power_supply_hwmon_info[] = {
> +static const struct hwmon_channel_info * const power_supply_hwmon_info[] = {
> HWMON_CHANNEL_INFO(temp,
> HWMON_T_LABEL |
> HWMON_T_INPUT |
> --
> 2.34.1
>

Attachment: signature.asc
Description: PGP signature