Re: [PATCH RFC v2 2/2] irqchip: irq-ti-sci-inta: Add direct mapped interrupts

From: Raghavendra, Vignesh
Date: Sat Apr 08 2023 - 07:28:54 EST


Hi,

On 4/8/2023 4:10 PM, Marc Zyngier wrote:
>> +static unsigned int ti_sci_inta_direct_events_am62x[] = {
>> + /* CPSW etherenti DMA events */
>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4627),
>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4635),
>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4643),
>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4651),
>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4659),
>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4667),
>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4675),
>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4683),
>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 5651),
>> +};
>> +
>> +static struct ti_sci_inta_soc_data soc_data_am62x = {
>> + .events_list = ti_sci_inta_direct_events_am62x,
>> + .events_list_size = ARRAY_SIZE(ti_sci_inta_direct_events_am62x),
>> +};
> I don't think these tables belong in a driver, and they are bound to
> grow without any obvious limits.

Fair point.

> You have firmware tables that can express these things. Surely they can be put to a good use.

By firmware tables you mean device tree?

Regards
Vignesh