Re: [PATCH v5 01/27] x86/boot: Align vmlinuz sections on page size

[Evgeniy Baskov]

On 2023-04-05 20:13, Borislav Petkov wrote:

Sorry for delayed reply.

> On Tue, Mar 14, 2023 at 01:13:28PM +0300, Evgeniy Baskov wrote:
> > To protect sections on page table level each section needs to be
> > aligned on page size (4KB).
>
> Protect against what?

Protect against invalid memory accesses, mainly caused by bugs, I guess.
I meant just applying tight memory attributes, sorry for the
bad wording. I will change it in the next version.

> > Set sections alignment in linker script for the kernel decompressor
> > (boot/compressed/vmlinux.lds.S).
>
> Do not talk about *what* the patch is doing in the commit message - 
> that
> should be obvious from the diff itself. Rather, concentrate on the 
> *why*
> it needs to be done.

Makes sense. I'll try to improve it before resubmitting.

> > Also introduce symbols that can be used to reference compressed
> > kernel blob section later in the later patches.
>
> Introduce those with the respective patch that uses them. This one is
> adding section alignment only and that's all that it should do.

Oh, good point, will do.

> Thx.

Thanks,
Evgeniy Baskov