Re: [PATCH 2/2] x86: make __get_wchan() use arch_stack_walk()

From: Josh Poimboeuf
Date: Sat Apr 08 2023 - 18:12:18 EST


On Sat, Apr 08, 2023 at 01:36:06PM +0800, Qi Zheng wrote:
>
>
> On 2023/4/8 13:08, Josh Poimboeuf wrote:
> > On Thu, Mar 30, 2023 at 04:15:52PM +0800, Qi Zheng wrote:
> > > Make __get_wchan() use arch_stack_walk() directly to
> > > avoid open-coding of unwind logic.
> > >
> > > Signed-off-by: Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx>
> >
> > Can we just have a shared version of __get_wchan() for all
> > CONFIG_ARCH_STACKWALK arches?
>
> From a quick glance, I think it's ok, but we still need to define
> the arch's own get_wchan_cb(). I will try to do it.

Hm, why would we need to do that?

--
Josh