Re: [PATCH v6 0/8] Add multiport support for DWC3 controllers

[Thinh Nguyen]

On Sat, Apr 08, 2023, Krzysztof Kozlowski wrote:
> On 08/04/2023 03:42, Thinh Nguyen wrote:
> >> Krishna Kurapati (8):
> >>   dt-bindings: usb: Add bindings for multiport properties on DWC3
> >>     controller
> >>   usb: dwc3: core: Access XHCI address space temporarily to read port
> >>     info
> >>   usb: dwc3: core: Skip setting event buffers for host only controllers
> >>   usb: dwc3: core: Refactor PHY logic to support Multiport Controller
> >>   usb: dwc3: qcom: Add multiport controller support for qcom wrapper
> >>   arm64: dts: qcom: sc8280xp: Add multiport controller node for SC8280
> >>   arm64: dts: qcom: sa8295p: Enable tertiary controller and its 4 USB
> >>     ports
> >>   arm64: dts: qcom: sa8540-ride: Enable first port of tertiary usb
> >>     controller
> >>
> >>  .../devicetree/bindings/usb/snps,dwc3.yaml    |  13 +-
> >>  arch/arm64/boot/dts/qcom/sa8295p-adp.dts      |  47 +++
> >>  arch/arm64/boot/dts/qcom/sa8540p-ride.dts     |  22 ++
> >>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi        |  58 +++
> >>  drivers/usb/dwc3/core.c                       | 373 ++++++++++++++----
> >>  drivers/usb/dwc3/core.h                       |  71 +++-
> >>  drivers/usb/dwc3/drd.c                        |  13 +-
> >>  drivers/usb/dwc3/dwc3-qcom.c                  |  28 +-
> >>  8 files changed, 523 insertions(+), 102 deletions(-)
> >>
> >> -- 
> >> 2.40.0
> >>
> > 
> > Please check if your patches and mailing client. Looks like they are
> > corrupted.
> 
> All patches look from patch-syntax and apply fine. What is exactly
> corrupted?
> 

Hm... perhaps it's an encoding issue from my mail client then. I get
this from my automated checks:

<snip>

ERROR: spaces required around that '=' (ctx:WxV)
#429: FILE: drivers/usb/dwc3/core.h:1697:
+		if (offset !=3D start && (id =3D=3D 0 || XHCI_EXT_CAPS_ID(val) =3D=3D id=
 		                                                               ^

ERROR: spaces required around that '=' (ctx:VxV)
#429: FILE: drivers/usb/dwc3/core.h:1697:
+		if (offset !=3D start && (id =3D=3D 0 || XHCI_EXT_CAPS_ID(val) =3D=3D id=
 		                                                                  ^

ERROR: spaces required around that '=' (ctx:VxE)
#429: FILE: drivers/usb/dwc3/core.h:1697:
+		if (offset !=3D start && (id =3D=3D 0 || XHCI_EXT_CAPS_ID(val) =3D=3D id=
 		                                                                        ^

ERROR: do not use assignment in if condition
#429: FILE: drivers/usb/dwc3/core.h:1697:
+		if (offset !=3D start && (id =3D=3D 0 || XHCI_EXT_CAPS_ID(val) =3D=3D id=

ERROR: spaces required around that '=' (ctx:WxV)
#433: FILE: drivers/usb/dwc3/core.h:1700:
+		next =3D XHCI_EXT_CAPS_NEXT(val);
 		     ^

ERROR: spaces required around that '+=' (ctx:WxV)
#434: FILE: drivers/usb/dwc3/core.h:1701:
+		offset +=3D next << 2;

</snip>


The "=" gets encoded to =3D, which is strange. It never happened before.
I need to check my mail client. Sorry for the noise.

Thanks,
Thinh