Re: [PATCH 1/4] dt-bindings: iio: dac: mcp4922: add vdd-supply property

From: Michael Welling
Date: Sun Apr 09 2023 - 16:53:10 EST


On Wed, Apr 05, 2023 at 04:01:11PM +0200, Nicolas Frattaroli wrote:
> These chips have a vdd supply input, which should be modelled in
> the bindings as well. Vref is only the voltage reference supply for
> the string DAC.
>
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@xxxxxxxxx>

Acked-by: Michael Welling <mwelling@xxxxxxxx>

> ---
> .../devicetree/bindings/iio/dac/microchip,mcp4922.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4922.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4922.yaml
> index 19374401e509..a3e80e90eeca 100644
> --- a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4922.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4922.yaml
> @@ -21,11 +21,14 @@ properties:
> reg:
> maxItems: 1
>
> + vdd-supply: true
> +
> vref-supply: true
>
> required:
> - compatible
> - reg
> + - vdd-supply
> - vref-supply
>
> allOf:
> @@ -42,6 +45,7 @@ examples:
> dac@0 {
> compatible = "microchip,mcp4912";
> reg = <0>;
> + vdd-supply = <&dac_reg>;
> vref-supply = <&dac_vref>;
> };
> };
> --
> 2.40.0
>