Re: [PATCH v2 2/3] drivers/perf: add DesignWare PCIe PMU driver

From: kernel test robot
Date: Mon Apr 10 2023 - 03:25:29 EST


Hi Shuai,

kernel test robot noticed the following build warnings:

[auto build test WARNING on soc/for-next]
[also build test WARNING on linus/master v6.3-rc6 next-20230406]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Shuai-Xue/drivers-perf-add-DesignWare-PCIe-PMU-driver/20230410-121727
base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
patch link: https://lore.kernel.org/r/20230410031702.68355-3-xueshuai%40linux.alibaba.com
patch subject: [PATCH v2 2/3] drivers/perf: add DesignWare PCIe PMU driver
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20230410/202304101501.5weSAuW5-lkp@xxxxxxxxx/config)
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/279673b15957e3ea9c14fded1e41a861a6d8b2d9
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Shuai-Xue/drivers-perf-add-DesignWare-PCIe-PMU-driver/20230410-121727
git checkout 279673b15957e3ea9c14fded1e41a861a6d8b2d9
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202304101501.5weSAuW5-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/perf/dwc_pcie_pmu.c:195:9: warning: no previous prototype for 'dwc_pcie_event_show' [-Wmissing-prototypes]
195 | ssize_t dwc_pcie_event_show(struct device *dev,
| ^~~~~~~~~~~~~~~~~~~


vim +/dwc_pcie_event_show +195 drivers/perf/dwc_pcie_pmu.c

194
> 195 ssize_t dwc_pcie_event_show(struct device *dev,
196 struct device_attribute *attr, char *page)
197 {
198 struct dwc_pcie_event_attr *eattr;
199
200 eattr = container_of(attr, typeof(*eattr), attr);
201
202 if (eattr->type == DWC_PCIE_LANE_EVENT)
203 return sprintf(page, "eventid=0x%lx, type=0x%lx, lane=0x%lx\n",
204 (unsigned long)eattr->eventid,
205 (unsigned long)eattr->type,
206 (unsigned long)eattr->lane);
207 else
208 return sprintf(page, "eventid=0x%lx, type=0x%lx",
209 (unsigned long)eattr->eventid,
210 (unsigned long)eattr->type);
211 }
212

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests