Re: [PATCH v2 1/3] tools/nolibc/stdio: Implement vprintf()

[Shuah Khan]

On 4/6/23 12:43, Paul E. McKenney wrote:
> On Thu, Apr 06, 2023 at 08:26:09PM +0200, Willy Tarreau wrote:
> > On Thu, Apr 06, 2023 at 05:19:10PM +0100, Mark Brown wrote:
> > > vprintf() is equivalent to vfprintf() to stdout so implement it as a simple
> > > wrapper for the existing vfprintf(), allowing us to build kselftest.h.
> > >
> > > Suggested-by: Willy Tarreau <w@xxxxxx>
> > > Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
> > > ---
> > >   tools/include/nolibc/stdio.h | 6 ++++++
> > >   1 file changed, 6 insertions(+)
> > >
> > > diff --git a/tools/include/nolibc/stdio.h b/tools/include/nolibc/stdio.h
> > > index 96ac8afc5aee..6cbbb52836a0 100644
> > > --- a/tools/include/nolibc/stdio.h
> > > +++ b/tools/include/nolibc/stdio.h
> > > @@ -273,6 +273,12 @@ int vfprintf(FILE *stream, const char *fmt, va_list args)
> > >   	return written;
> > >   }
> > >   
> > > +static __attribute__((unused))
> > > +int vprintf(const char *fmt, va_list args)
> > > +{
> > > +	return vfprintf(stdout, fmt, args);
> > > +}
> > > +
> > >   static __attribute__((unused, format(printf, 2, 3)))
> > >   int fprintf(FILE *stream, const char *fmt, ...)
> > >   {
> >
> > Perfect, thank you Mark, I'm glad that it simplified the rest of
> > your series.
> >
> > Acked-by: Willy Tarreau <w@xxxxxx>
> >
> > Paul, feel free to directly queue this one for 6.5. If you prefer I
> > can as well queue it on my side and send it later, it's just that I
> > have exactly zero extra value on top of this one ;-)
>
> Alternatively, if it would be more convenient for Mark to send this
> up via kselftest:
>
> Acked-by: Paul E. McKenney <paulmck@xxxxxxxxxx>
>
> It currently merges cleanly with the -rcu tree's dev branch, so this
> should not be a problem.
>
> Either way, please let me know, Mark!
>
> 						

I can take these through kselftest or can go through arm64

Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

thanks,
-- Shuah